Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32873

Separate out course ajax enabled checking to separate function

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.3
    • 2.3
    • Course
    • MOODLE_23_STABLE
    • MOODLE_23_STABLE
    • MDL-32873-master-1
    • Hide

      Open a course page with a number of course modules present

      • Ensure that all of the AJAX resource buttons still work
        • right/left
        • show/hide
        • group mode toggle (on activities)
        • delete
        • drag/drop
      • Ensure that the AJAX section buttons work as inticipated
        • show/hide
        • drag/drop

      Then:

      • disable ajax support by turning off the 'enableajax' setting
        • confirm that we're back to the non-ajax versions

      For bonus points:

      • (re-enable the sitewide enableajax setting)
      • open your current theme's config.php and add:

        $THEME->enablecourseajax = false;

        • confirm that we're back to the non-ajax versions of all icons
        • remove the theme config line
      • open your current format's lib.php and find the callback_$name_ajax_support function and change the capable line:

        $ajaxsupport->capable = false;

        • confirm that we're back to the non-ajax versions of all icons
        • change things back to normal
      Show
      Open a course page with a number of course modules present Ensure that all of the AJAX resource buttons still work right/left show/hide group mode toggle (on activities) delete drag/drop Ensure that the AJAX section buttons work as inticipated show/hide drag/drop Then: disable ajax support by turning off the 'enableajax' setting confirm that we're back to the non-ajax versions For bonus points: (re-enable the sitewide enableajax setting) open your current theme's config.php and add: $THEME->enablecourseajax = false; confirm that we're back to the non-ajax versions of all icons remove the theme config line open your current format's lib.php and find the callback_$name_ajax_support function and change the capable line: $ajaxsupport->capable = false; confirm that we're back to the non-ajax versions of all icons change things back to normal

      For MDL-31215 and others we sometimes need to check whether AJAX should be enabled so it would be beneficial to split this into a separate function.

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Dan Poltawski Dan Poltawski
            Sam Hemelryk Sam Hemelryk
            Rossiani Wijaya Rossiani Wijaya
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.