Loading...

XML

Word

Printable

Affected Branches:
MOODLE_22_STABLE
Fixed Branches:
MOODLE_23_STABLE
Pull from Repository:
git://github.com/andyjdavis/moodle.git
Pull Main Branch:
~~MDL-32860~~_user_iterator
Pull Main Diff URL:
https://github.com/andyjdavis/moodle/compare/master...MDL-32860_user_iterator
Testing Instructions:

Hide

Testing is just a matter of making sure I didnt break anything. Do the following and check that it all still works.

Do a grade export in each format. txt, xls, xml, ods.

Go to the user report in the gradebook. Select and user from the drop down and check that displays fine.

Show
Testing is just a matter of making sure I didnt break anything. Do the following and check that it all still works. Do a grade export in each format. txt, xls, xml, ods. Go to the user report in the gradebook. Select and user from the drop down and check that displays fine.

Member variables have no php docs. Check all php docs while we're at it.

All public member variables. Is that really necessary?

There are some methods whose names start with and underscore. Are they meant to be private or protected?

has a non-specific relationship to

MDL-27322 Suspended Students in exported gradebook, indistinguishable from Active Students