Loading...

XML

Word

Printable

Affected Branches:
MOODLE_22_STABLE
Fixed Branches:
MOODLE_23_STABLE
Pull from Repository:
git://git.luns.net.uk/moodle.git
Pull Main Branch:
~~MDL-32641~~-master-1
Pull Main Diff URL:
https://git.luns.net.uk/moodle.git/commitdiff/96c8f933fd71274ef11e2e315b733400754e9c38
Testing Instructions:
Hide

Enable the feedback activity

Add a new feedback activity

Choose Save and Display

Select 'Edit questions'

Choose a question

Confirm that the page changes without showing a form change warning

Create the question

Choose the Templates tab

Save questions as a new template

Select the template you just created from the dropdown list

Confirm that the page changes without showing a form change warning
Show
Enable the feedback activity Add a new feedback activity Choose Save and Display Select 'Edit questions' Choose a question Confirm that the page changes without showing a form change warning Create the question Choose the Templates tab Save questions as a new template Select the template you just created from the dropdown list Confirm that the page changes without showing a form change warning

Add a feedback activity
try editing questions of this activity
Each time you select an entry from drop down it pops up a confirmation msg "do you want to stay or leave"
This popup is not at all required at this point and is really annoying.
Thanks

Discovered while testing

MDL-32735 Strict standards error in Feedback edit page

duplicates

MDL-32070 Form warnings triggered when edit_form submitted with onChange JS

Participants:: Andrew Lyons, Ankit Agarwal, Dan Poltawski, Eloy Lafuente (stronk7), Sam Hemelryk