Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32146

Simple and Full View does not adhere to "Show calculations" preference

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: Minor Minor
    • None
    • 2.2.1, 2.2.2
    • Gradebook
    • MOODLE_22_STABLE
    • Hide
      • Create a course
      • Go to "Grades"
      • Click on the dropdown at the top, and select "Simple" or "Full" view under Categories and Items
      • Add a manual grade item
      • Verify that the calculation icon (little calculator) appears in the item action link with delete, edit, move, etc.
      • Click on the dropdown at the top, and select "Grader report" under "My Preferences"
      • "Show calculations" is the first setting...turn it on or off.
      • Go back to Simple or full view.
      • Page should respond to setting.
      Show
      Create a course Go to "Grades" Click on the dropdown at the top, and select "Simple" or "Full" view under Categories and Items Add a manual grade item Verify that the calculation icon (little calculator) appears in the item action link with delete, edit, move, etc. Click on the dropdown at the top, and select "Grader report" under "My Preferences" "Show calculations" is the first setting...turn it on or off. Go back to Simple or full view. Page should respond to setting.

      There is a grader report setting call "Show calculations", that allows instructors to hide or show the calculation icon. The simple and full edit views (where the icon actually appears), does not check that setting at all. By running a grep on the codebase, it appears that the setting has no affect on Moodle at all, except the existence of the preference. The patch I included simply checks the setting, and conditionally shows the icon if the preference is true.

            Unassigned Unassigned
            pcali1 Philip Cali (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.