Loading...

XML

Word

Printable

Affected Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
Fixed Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE
Pull from Repository:
git://github.com/mouneyrac/moodle.git
Pull Main Branch:
~~MDL-31762~~
Pull Main Diff URL:
https://github.com/mouneyrac/moodle/compare/master...MDL-31762
Testing Instructions:

Hide

Call create/update user web service function with uppercase username. The web service call should fail. you can use tge demo client for it: https://github.com/moodlehq/sample-ws-clients/tree/master/PHP-REST

Show
Call create/update user web service function with uppercase username. The web service call should fail. you can use tge demo client for it: https://github.com/moodlehq/sample-ws-clients/tree/master/PHP-REST

While reviewing a change Apu was making (~~MDL-25027~~) I noticed a couple of thigns that the webservice function that creates users was missing:

Username must be lower case (reference: https://github.com/samhemelryk/moodle/blob/master/user/editadvanced_form.php#L172)
Username should be using PARAM_USERNAME or at least cleaning with it and checking for differences (reference as above)
user_create_user should be checking password policy etc (I think there may be an issue for this)

Cheers
Sam

caused a regression

MDL-33352 Regression: usage of textlib static interface in Moodle2.1

has a non-specific relationship to

MDL-31253 META - web service improvements for 2.3

has been marked as being related by

MDL-31714 Core needs centralized data validations for use by core and web services too. truncate_userinfo() not good enough.

Participants:: Aparup Banerjee, Eloy Lafuente (stronk7), Jason Ilicic, Jérôme Mouneyrac, Rajesh Taneja, Rossiani Wijaya, Sam Hemelryk