Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31569

build_activity_plan can be optimized

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Inactive
    • Icon: Minor Minor
    • None
    • 2.2.1
    • Backup
    • MOODLE_22_STABLE

      While working on MDL-25432, I realized while building activity plan (build_activity_plan()), we call get_backup_activity_task which is checking for course module and creates backup_activity_task.
      Also, any backup activity task extends backup_activity_task, in which constructor also checks for course module.

      In get_coursemodule_from_id(), we are making two sql calls. It will be nice to pass coursemodule information in constructor of backup_*_activity_task and we can avoid second redundant check.

            Unassigned Unassigned
            rajeshtaneja Rajesh Taneja
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.