Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31301

textlib functions should be called as static methods

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.3
    • 2.2.1
    • Other
    • MOODLE_22_STABLE
    • MOODLE_23_STABLE
    • w10_MDL-31301_m23_textlibcleanup
    • Hide

      no idea how to test it, I did the patch using trivial search replace, there should not be any regressions...

      • Running and passing all the tests under master may be a good enough way to control that nothing has gone out of control
      Show
      no idea how to test it, I did the patch using trivial search replace, there should not be any regressions... Running and passing all the tests under master may be a good enough way to control that nothing has gone out of control

      In MDL-29027 textlib functions became static, but calling for this function is not changed. They are still called as textlib->substr(). It should be changed to textlib::substr().

            skodak Petr Skoda
            rajeshtaneja Rajesh Taneja
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.