Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31240

Fix test_format_string() to test any $CFG->formatstringstriptags status

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Not a bug
    • Icon: Minor Minor
    • None
    • 2.1.4, 2.2.1, 2.3
    • Filters, Unit tests
    • MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Easy
    • Hide
      • In admin interface set $CFG->formatstringstriptags = enabled
      • Run lib/simpletest/testweblib.php unittests.
      • TEST: No failures happen related for test_format_string()
      • In admin interface set $CFG->formatstringstriptags = disabled
      • Run lib/simpletest/testweblib.php unittests.
      • TEST: No failures happen related for test_format_string()
      • Note, under windows, it's possible to get some other failure when running lib/simpletest/testweblib.php, ignore it, we'll catch all them once the VMs are available. Just check none of them are related to test_format_string()
      Show
      In admin interface set $CFG->formatstringstriptags = enabled Run lib/simpletest/testweblib.php unittests. TEST: No failures happen related for test_format_string() In admin interface set $CFG->formatstringstriptags = disabled Run lib/simpletest/testweblib.php unittests. TEST: No failures happen related for test_format_string() Note, under windows, it's possible to get some other failure when running lib/simpletest/testweblib.php, ignore it, we'll catch all them once the VMs are available. Just check none of them are related to test_format_string()

      Running unittests for MDL-29091 revealed that the tests present @ test_format_string() are dependent of the status of the $CFG->formatstringstriptags setting, and they only pass if the setting is enabled (default status).

      This issue is about to fix that testing unit to support and test both modes, bringing independence from the $CFG var.

      That is.

            rushi963 Rushikesh Nalla
            stronk7 Eloy Lafuente (stronk7)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.