Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.3.6, 4.4.2
Affects Version/s: 2.2.1, 4.3.6, 4.4.2
Component/s: Web Services
Labels:
- ci
- triaged

Affected Branches:
MOODLE_22_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE
Fixed Branches:
MOODLE_403_STABLE, MOODLE_404_STABLE
Epic Link:
TODOs in core
Pull from Repository:
https://github.com/ziegenberg/moodle
Pull 4.3 Branch:
~~MDL-31192~~-M403_colored-box-with-pre-tag-function-generates-a-warning
Pull 4.3 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_403_STABLE...ziegenberg:MDL-31192-M403_colored-box-with-pre-tag-function-generates-a-warning
Pull 4.4 Branch:
~~MDL-31192~~-M404_colored-box-with-pre-tag-function-generates-a-warning
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...ziegenberg:MDL-31192-M404_colored-box-with-pre-tag-function-generates-a-warning
Pull Main Branch:
~~MDL-31192~~_colored-box-with-pre-tag-function-generates-a-warning
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...ziegenberg:MDL-31192_colored-box-with-pre-tag-function-generates-a-warning
Testing Instructions:
Hide

Login as admin.

Go to Site administration > Server > Web services > Documentation

Expand a couple of collapsible web service functions and compare the appearance with another site without the patch.

Verify the page renders without any visual differences than before the patch.
Show
Login as admin. Go to Site administration > Server > Web services > Documentation Expand a couple of collapsible web service functions and compare the appearance with another site without the patch. Verify the page renders without any visual differences than before the patch.

There is a TODO saying:

public function colored_box_with_pre_tag($title, $content, $rgb = 'FEEBE5') {

//TODO: this tag removes xhtml strict error but cause warning

I don't remember exactly what it is but it needs to be checked...

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 4 Passed -- (Main)MDL-31192.png
113 kB
03/Jul/24 3:53 PM

has been marked as being related by

MDL-82269 PR only: MDL-31192 - webservice/renderer.php: colored_box_with_pre_tag() function generates a warning

Closed

Assignee:: Daniel Ziegenberg

Reporter:: Jérôme Mouneyrac

Peer reviewer:: Meirza

Integrator:: Jun Pataleta

Tester:: Kim Jared Lucas

Participants:: CiBoT, Daniel Ziegenberg, Jérôme Mouneyrac, Jun Pataleta, Kim Jared Lucas, Marina Glancy, Matt Porritt, Meirza, Paul Holden

Votes:: 0 Vote for this issue

Watchers:: 9 Start watching this issue

Created:: 16/Jan/12 7:58 PM

Updated:: 05/Jul/24 10:04 AM

Resolved:: 05/Jul/24 10:04 AM

Estimated:

Remaining:

Logged:

1h 30m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify