Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31152

tag/lib.php todo: Check if commented out piece of code "helps performance without breaking anything"

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Deferred
    • Icon: Minor Minor
    • None
    • 2.2
    • Tags

      This issue is creating an associated MDL for an orphan TODO in tag/lib.php, which I came across while working on [MDL-30992]...

      tag/lib.php

      //TODO: test this and see if it helps performance without breaking anything
      //foreach($tags as $key => $tag) {
      //    $clean_tag = moodle_strtolower($tag);
      //    if ( array_key_exists($clean_tag), $tag_id_cache) ) {
      //        $result[$clean_tag] = $tag_id_cache[$clean_tag];
      //        $tags[$key] = ''; // prevent further processing for this one.
      //    }
      //}

      The above code is an extract from the tag_get_id() function in tag/lib.php. The todo comment pretty much says it all.

            Unassigned Unassigned
            gerry Gerard Caulfield
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.