Loading...

XML

Word

Printable

Affected Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
Fixed Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE
Pull from Repository:
https://github.com/davosmith/moodle
Pull Main Branch:
~~MDL-31113~~_multiple_files_file_manager
Pull Main Diff URL:
https://github.com/davosmith/moodle/commit/910e1ecdaaceff0f4c87ba38528d2992c6fe9bfb
Testing Instructions:
Hide

NOTE to testers: This needs to be tested under STABLE (21 or 22) and master. And master needs to be tested with normal (upload) and also drag and drop one.

Go to course -> forum

upload a file (File will be visible in file manager)

Press browser back button

Press browser forward button

file should be visible in file manager

try upload another file

You should get error message
Show
NOTE to testers: This needs to be tested under STABLE (21 or 22) and master. And master needs to be tested with normal (upload) and also drag and drop one. Go to course -> forum upload a file (File will be visible in file manager) Press browser back button Press browser forward button file should be visible in file manager try upload another file You should get error message

User can fool filemanager to upload multiple files even though max files is set.

Using Drag and drop (DND) also you can see this issue:

Upload a file using DND
Try uploading another file (I used PDF)
PDF opens (Which user don't expect IMO)
Press browser back button, no file is visible
Drag and drop another file, you will see two file. (This is related to file manager issue mentioned below.)
Save post and both files get uploaded.

Testing discovered

MDL-29766 Add drag and drop capabilities to the Filemanager element

Participants:: Dan Poltawski, Davo Smith, Eloy Lafuente (stronk7), Rajesh Taneja, Sam Hemelryk