Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30613

$FULLME should not be used for https detection

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • 2.2.1
    • 2.2, 2.3
    • General
    • MOODLE_22_STABLE, MOODLE_23_STABLE
    • MOODLE_22_STABLE
    • w51_MDL-30613_m23_FULLME
    • Hide

      1/ make sure standard sites with adn without ssl work as before (test especially login with and without automatic guest login)
      2/ try sites with loginhttps
      3/ in head try LTI and gravatar on ssl sites

      Show
      1/ make sure standard sites with adn without ssl work as before (test especially login with and without automatic guest login) 2/ try sites with loginhttps 3/ in head try LTI and gravatar on ssl sites

      $FULLME ca not be used for https detection because it breaks ssl proxies, instead we must use $CFG->httpswwwroot.

      I am going to comment in the pagelib because it seems ppl copy pasted it from there - it is a special case and it is intentionally not compatible with ssl proxies...

            skodak Petr Skoda
            skodak Petr Skoda
            Aparup Banerjee Aparup Banerjee
            Rajesh Taneja Rajesh Taneja
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.