-
Task
-
Resolution: Duplicate
-
Minor
-
None
-
2.0.5, 2.1.2, 2.2
-
MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
Before 2.x we needed to use the $DB->sql_empty() helper method in a lot of places (basically each time that one '' (empty string) was searched/used.
But under 2.x a lot of those uses are not necessary anymore when the '' is used in any param (each moodle_database driver will handle it as necessary as part of the binding process).
This reduces the use of the helper function exclusively to the places where '' is used within one SQL statement. The rest (params in general) should be changed to ''.
This issue is about to perform that cleanup and test all the changes under Oracle (the only one needing the special handling of '') and another DB (mysql|postgres|mssql) to verify that everything continues working ok.
Surely master only. Ciao
- has been marked as being related by
-
MDL-28483 adding URL resource without an url leads to error
-
- Closed
-
-
MDL-30761 Performance regression: slow login because get_user_access_sitewide takes way too long since moodle 2.2
-
- Closed
-
- will be (partly) resolved by
-
MDL-37742 simplify dirty one-space oracle hack
-
- Closed
-