Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29261

Upload users should indicate field containing incorrect data

XMLWordPrintable

    • MOODLE_21_STABLE, MOODLE_401_STABLE
    • MOODLE_402_STABLE, MOODLE_403_STABLE
    • MDL-29261-403
    • Hide

      don't make the mistake of entering full country names instead of 2 letter country codes

      Show
      don't make the mistake of entering full country names instead of 2 letter country codes
    • Hide
      1. Log in as admin
      2. Navigate to Users > Accounts > Upload users in site administration
      3. Upload example.csv and press Upload users
      4. Leave defaults and press Upload users
      5. Confirm the Status column for student2 shows:

        Invalid data detected for user 'student2' (country), which has been automatically cleaned.
        

      Show
      Log in as admin Navigate to Users > Accounts > Upload users in site administration Upload example.csv and press Upload users Leave defaults and press Upload users Confirm the Status column for student2 shows: Invalid data detected for user 'student2' (country), which has been automatically cleaned.

      Original report

      Uploading users via csv file does not give a warning status if country column contains real country names rather than country codes. Submitting the file with full country names results in a misleading 'Error writing to database' message.

      Addendum

      The above has been resolved, there is no longer a DML exception throw because of automatic cleaning of the uploaded data

      However, there is no indication given to the user which data is invalid and is being automatically cleaned:

      This makes it very hard for a user to actually fix the file content (because they don't know what's broken in it). We should fix that, hence re-opening

        1. example.csv
          0.1 kB
          Paul Holden
        2. MDL-29261.png
          129 kB
          Ron Carl Alfon Yu
        3. Screenshot 2023-11-22 at 12-06-36 Upload users Accounts Users Administration Docker.png
          42 kB
          Paul Holden

            pholden Paul Holden
            kevin.mueller Kevin Mueller
            Andrew Lyons Andrew Lyons
            Huong Nguyen Huong Nguyen
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            2 Vote for this issue
            Watchers:
            17 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 32 minutes
                1h 32m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.