We had reports that graders were not able to see question attempts in the manual grading report.

Investigation shows that this happens after closed essay attempts have a quiz regrade performed on them, they are left in the SUBMIT state rather than the CLOSED state as they previously were. This means they do not display in the manual grading or overview reports as requiring grading.

To reproduce:
1) create a quiz with essay question
2) attempt quiz as student or with student account, save and submit answers, close attempt
3) grader report shows question needs marking
4) run regrade all, overview no longer shows 'requires grading' on questions
5) manual grading report says nothing to display

My patch for this is to set the question state to closed in the essay question grading function, and tests show this seems to result in the correct behavior.

github link incoming shortly...