Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29158

Review repository code and improve quality and coding standard

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Do
    • Icon: Minor Minor
    • None
    • 2.1.1
    • Repositories
    • MOODLE_21_STABLE

      While reviewing a recent boxnet repository issue I notice several things that can be improved with the repository API including one that issue that will result in notices.
      The following are my suggestions:

      • Review all repository classes and create appropriately scoped poperty declarations. Presently there are MANY missing.
      • repository_boxnet::get_option uses $options before it is defined. Will result in a notice if that code is ever accessed.
      • Whitespace issues everywhere in the repository code!
      • bonnet::get_listing unused variables

      In summary: Review repository code, identify areas of improvement, create sub issues, complete.

      The code in generally Ok so this should be a pretty quick issue.

            Unassigned Unassigned
            samhemelryk Sam Hemelryk
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.