Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28588

Remove IN from sql statments in Basic report plugin

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.2.1
    • 2.2
    • SCORM

      In mod/scorm/report/basic/report.php
      SQL IN statements are used as mentioned below:-
      $where = ' WHERE u.id IN (' .$allowedlist. ') AND st.userid IS NOT NULL';
      $where = ' WHERE u.id IN (' .$allowedlist. ') AND st.userid IS NULL';
      $where = ' WHERE u.id IN (' .$allowedlist. ') AND (st.userid IS NOT NULL OR st.userid IS NULL)';

      as per new moodle standards no sql statements should use IN directly in this way
      Reference: http://docs.moodle.org/dev/DB_layer_2.0_migration_docs#The_golden_changes (G7)

            ankit_frenz Ankit Agarwal
            ankit_frenz Ankit Agarwal
            Tim Hunt Tim Hunt
            Sam Hemelryk Sam Hemelryk
            Rajesh Taneja Rajesh Taneja
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.