This follows on from MDL-27829.

Using the standard Moodle editing interface, you can only set certain values for pagetypepatterns for blocks. This is all that most people will want.

However, the underlying blocks system is capable of being much more flexible that that. Do we want to support power-admins who want to do weird things by, for example, putting custom values directly in the blocks table.

All I propose we do is what is already suggested in a comment in the code:

} else {

    //as a last resort we could put the page type pattern in the select box

    //however this causes mod-data-view to be added if the only option available is mod-data-*

    //as a last resort we could put the page type pattern in the select box

    //however this causes mod-data-view to be added if the only option available is mod-data-*

    // so we are just showing a warning to users about their prev setting being reset

    $displaypagetypewarning = true;

}

I suggest that we do actually add the custom page-type to the menu, with a clear lang string like "Special non-standard value 'mod-pony-*-foal'".