Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Major
Fix Version/s: 2.1
Affects Version/s: 2.1
Component/s: Backup
Labels:
- triaged

Affected Branches:
MOODLE_21_STABLE
Fixed Branches:
MOODLE_21_STABLE
Pull from Repository:
git://github.com/stronk7/moodle.git
Pull Main Branch:
~~MDL-27594~~
Pull Main Diff URL:
https://github.com/stronk7/moodle/compare/master...MDL-27594
Difficulty:
Moderate
Testing Instructions:
Hide

Enable DEBUG = developer

Run the unit tests (Admin -> Developer -> Unit tests) by specifying "backup/util/xml/parser".

TEST: All tests pass ok.

TEST: The number of tests is, at least, 248

TEST: Restore some 2.x course, it should finish as usual
Show
Enable DEBUG = developer Run the unit tests (Admin -> Developer -> Unit tests) by specifying "backup/util/xml/parser". TEST: All tests pass ok. TEST: The number of tests is, at least, 248 TEST: Restore some 2.x course, it should finish as usual

This is one followup of ~~MDL-27475~~, where David discovered one real example of start/process/end notifications not happening in correct order under some circumstances (empty chunks).

The fix changes completely the way start/end notifications were dispatched previously, by implementing one simple stack of pending notifications and dispatching them when necessary.

The fix adds 2 new test cases covering the trouble-maker situation (exaggerated!), without modifying previous tests, so no change is expected in behavior at all (BC ok).

has a non-specific relationship to

MDL-27475 Modify start/dispatch/end notifications to be called in correct order

Closed

MDL-37893 PHP error when parsing XML backup and the grouped element contains no final elements

Closed

has been marked as being related by

MDL-27693 Yet another issue with the order of start/process/end handlers in the progressive parser

Closed

Assignee:: Eloy Lafuente (stronk7)

Reporter:: Eloy Lafuente (stronk7)

Integrator:: Sam Hemelryk

Tester:: Sam Hemelryk

Participants:: Aparup Banerjee, Eloy Lafuente (stronk7), Sam Hemelryk

Votes:: 0 Vote for this issue

Watchers:: 0 Start watching this issue

Created:: 23/May/11 2:55 PM

Updated:: 08/Feb/13 8:34 AM

Resolved:: 26/May/11 2:58 PM

Details

Description

Attachments

Issue Links

Activity

People

Dates

Clockify