Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27562

Timezone option not considered in dateselector and datetimeselector form element

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • 2.3
    • 1.9.12, 2.0
    • Forms Library
    • MOODLE_19_STABLE, MOODLE_20_STABLE
    • MOODLE_23_STABLE
    • wip-mdl-27562
    • Hide

      run php unit test for dateselector and datetimeselector

      phpunit dateselector_form_element_testcase lib/form/tests/dateselector_test.php
      phpunit datetimeselector_form_element_testcase lib/form/tests/datetimeselector_test.php

      Show
      run php unit test for dateselector and datetimeselector phpunit dateselector_form_element_testcase lib/form/tests/dateselector_test.php phpunit datetimeselector_form_element_testcase lib/form/tests/datetimeselector_test.php

      /lib/form/dateselector.php doesn't pass configurable option 'timezone' to function usergetdate() as 2nd parameter.

      In function: onQuickFormEvent($event, $arg, &$caller)
      Change:
       
          if (!is_array($value)) {
              $currentdate = usergetdate($value);
              $value = array(
       
      To:
       
          if (!is_array($value)) {
              $currentdate = usergetdate($value, $this->_options['timezone']);
              $value = array(

        1. test.php
          0.8 kB
        2. test-dst.php
          1.0 kB

            rajeshtaneja Rajesh Taneja
            brentb Brent Boghosian
            Jason Fowler Jason Fowler
            Sam Hemelryk Sam Hemelryk
            Sam Hemelryk Sam Hemelryk
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.