Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27313

Flickr Public repository has undefined propety when 'usewatermarks' checkbox is not set

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.0.4
    • 2.0.2, 2.1
    • Repositories
    • None
    • Windows server 2008 R2 ; PHP 5.3.5; MS SQL 2008 R2
    • Microsoft SQL
    • MOODLE_20_STABLE, MOODLE_21_STABLE
    • MOODLE_20_STABLE
    • s10_MDL-27341_flickr_plugin_master
    • Hide

      Create a FLickr_pubic repository instance and save the insatnce setting with an e-mail address and the checkbox cleared, do it again with the checkbox checked, no error, do it agin with checkbox unchecked, error recorrs and setting remains set in DB.

      Show
      Create a FLickr_pubic repository instance and save the insatnce setting with an e-mail address and the checkbox cleared, do it again with the checkbox checked, no error, do it agin with checkbox unchecked, error recorrs and setting remains set in DB.

      When configuring an instance of Flickr Public repository, when the 'usewatermarks' checkbox is cleared (the default) this error is generated:

      Undefined property: stdClass::$usewatermarks in moodle\admin\repositoryinstance.php on line 71

      If the checkbox is checked, there are no errors. However, the 'usewatermarks' setting in the database remains set to 1 and can't be unset using the moodle admin form.

      Originally there was also another error when the checkbox was unchecked:

      Undefined index: usewatermarks in moodle\repository\lib.php on line 1247

      This issue is resolved by adding a default value for the checkbox in function 'instance_config_form' in moodle\repository\flickr_public\lib.php

      insert at line 459: $mform->setDefault('usewatermarks', 0);

            dongsheng Dongsheng Cai
            mark.emery Mark Emery
            Aparup Banerjee Aparup Banerjee
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Michael de Raadt Michael de Raadt
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.