Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Critical
Fix Version/s: 2.1
Affects Version/s: 2.1.4, 2.2.1, 2.5, 2.6.3, 2.7
Component/s: Course completion, Usability
Labels:
- partner
- patch
- pukunui
- triaged
Environment:
PHP Version 5.3.3
Apache/2.2.16
MySQL 5.1.49

Affected Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
Fixed Branches:
MOODLE_21_STABLE
Pull from Repository:
https://github.com/totara/moodle.git
Pull Main Branch:
~~MDL-27114~~b
Pull Main Diff URL:
https://github.com/totara/moodle/commit/9d9ca3d76bcf614198dbc1c4d1dd17237b51f520
Testing Instructions:

Hide

Create 3 courses with completion enabled, enable "self completion" via completion settings for each.

Go to one of the courses, select both other courses in the "course prerequisites" select box in completion settings, save.

Revisit the form, deselect both courses and save.

Before fix:
The change would not have been saved.

After fix:
Changes would be saved, no prerequisites would be selected.
"Select none" checkbox also exists for same purpose.

Show
Create 3 courses with completion enabled, enable "self completion" via completion settings for each. Go to one of the courses, select both other courses in the "course prerequisites" select box in completion settings, save. Revisit the form, deselect both courses and save. Before fix: The change would not have been saved. After fix: Changes would be saved, no prerequisites would be selected. "Select none" checkbox also exists for same purpose.

When editing course completion settings, one can chose one or several courses as "course prerequisites". If one makes a mistake, one can modify the chosen elements (courses) in this "select multiple" HTML element. However, if one wants to remove all selection (i.e. not chose any course as prerequisite anymore), the choice is not saved. The application acts as if not receiving any input from this part of the form.

It is therefore not possible to remove all course prerequisites after having chosen one (or several) in the first place.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

27114.png
10/Jan/12 5:21 PM
14 kB
Sam Hemelryk

caused a regression

MDL-34958 Course completion duplicate records

Closed

is duplicated by

MDL-24143 Deadlock problem in completion tracking

Closed

MDL-31663 "Course prerequisites" in course completion tracking settings not saved properly

Closed

Assignee:: Unassigned

Reporter:: Nicolas Dunand

Integrator:: Sam Hemelryk

Participants:: Aaron Barnes, Adam Barbary, Amanda Doughty, Amir Elion, Andrea Gordon, Helen Foster, ilan cohen, Marina Glancy, Mary Cooch, Mia Musolino, Michael de Raadt, Nicolas Dunand, Paul Vasilauskis, Phil Everist, Sam Hemelryk

Votes:: 22 Vote for this issue

Watchers:: 23 Start watching this issue

Created:: 08/Apr/11 3:35 AM

Updated:: 28/Jul/18 1:15 AM

Resolved:: 27/Jul/15 7:28 PM

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Clockify