Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-26922

Overflow problems on mssql & sqlsrv DB drivers with tests using PHP_INT_MAX

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Critical Critical
    • 2.0.3
    • 2.0.2
    • Database SQL/XMLDB
    • MSSQL/SQLSRV unit tests
    • Microsoft SQL
    • MOODLE_20_STABLE
    • MOODLE_20_STABLE
    • Moderate

      Although highly improvable in real use... it seems that both the MSSQL and SQLSRV drivers are exposed to overflow problems when PHP_INT_MAX is used in limit tests.

      This is caused by this happening:

      $fetch = $limitfrom + $limitnum;

      So if both exist and they are bigger than PHP_INT_MAX, overflow => error happens.

      Fix is really parallel to the one applied @ MDL-26844 for PostgreSQL.

      Working on it. Ciao

            stronk7 Eloy Lafuente (stronk7)
            stronk7 Eloy Lafuente (stronk7)
            Sam Hemelryk Sam Hemelryk
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.