Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-26502

'Symbian' is misspelt, so browser check gives false positives

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Trivial Trivial
    • 1.9.12, 2.0.3
    • 1.9.10, 2.0
    • Libraries
    • None
    • n/a
    • MOODLE_19_STABLE, MOODLE_20_STABLE
    • MOODLE_19_STABLE, MOODLE_20_STABLE
    • Easy

      'Symbian' is misspelt as 'Simbian' in moodlelib.php

      This means that some phones that should be rejected are accepted as having qualifying user agents.

      For example, with the user agent string for a Nokia N97:

      Mozilla/5.0 (SymbianOS/9.4; Series60/5.0 NokiaN97-1/12.0.024; Profile/MIDP-2.1 Configuration/CLDC-1.1; en-us) AppleWebKit/525 (KHTML, like Gecko) BrowserNG/7.1.12344

      check_browser_version('Safari') returns true. The expected behaviour is that it would return false, rejecting the phone due to the term 'SymbianOS' in the UA string.

        1. testua.php
          0.3 kB
          Daren Chandisingh

            darenc Daren Chandisingh (Inactive)
            darenc Daren Chandisingh (Inactive)
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.