-
Bug
-
Resolution: Fixed
-
Critical
-
2.3
-
None
-
MOODLE_23_STABLE
-
MOODLE_23_STABLE
-
wip-
MDL-26155-m23 -
- Review the code changes to spot holes.
- Run the unit tests in lib/simpletest/testmoodlelib.php
- Expand the admin tree in the settings block and check a couple of pages.
While working on MDL-24125 I noted that a great deal of the time that goes into generating the admin tree is put into get_string calls, of which even with the navigation using the tree most are not used.
After a bit of investigation and testing I have come up with a solution that makes use of a class with a __toString method to delay the get_string call until it is needed. This reduced the page load time on average by 25% and even reduced memory a little.
I'll post to a git branch with the solution shortly and provide some more performance information I have gathered.
Cheers
Sam