Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-25314

@ob_end_flush() in a few places...

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.0
    • 2.0
    • General
    • None
    • Any
    • MOODLE_20_STABLE
    • MOODLE_20_STABLE
    • Easy

      Just detected a bunch of remaining:

      @ob_end_flush();

      courrences here and there, more noticeably in filelib, causing all my test sites to stop sending files completely (because I've disabled the shut-up operator).

      I think it would be nice to change them to something avoiding those @ if possible, like we recently did in unittests and some ob_end_clean() uses. Perhaps encapsulating the whole loop within a function or so.

      grep -r '@ob_end_flush' *
       
      admin/bloglevelupgrade.php:while(@ob_end_flush());
      admin/multilangupgrade.php:while(@ob_end_flush());
      admin/report/security/index.php:while(@ob_end_flush());
      lib/adminlib.php:    while(@ob_end_flush());
      lib/filelib.php:    while (@ob_end_flush()); //flush the buffers - save memory and disable sid rewrite
      lib/filelib.php:        while (@ob_end_flush()); //flush the buffers - save memory and disable sid rewrite
      lib/filelib.php:            while (@ob_end_flush()); //flush the buffers - save memory and disable sid rewrite
      lib/filelib.php:            while (@ob_end_flush()); //flush the buffers - save memory and disable sid rewrite
      lib/filelib.php:            while (@ob_end_flush()); //flush the buffers - save memory and disable sid rewrite
      lib/filelib.php:        while (@ob_end_flush()); //flush the buffers - save memory and disable sid rewrite
      lib/filelib.php:            while (@ob_end_flush()); //flush the buffers - save memory and disable sid rewrite
      lib/filelib.php:            while (@ob_end_flush()); //flush the buffers - save memory and disable sid rewrite
      lib/filelib.php:            while (@ob_end_flush()); //flush the buffers - save memory and disable sid rewrite
      lib/filelib.php:        while (@ob_end_flush()); //flush the buffers - save memory and disable sid rewrite
      lib/filelib.php:        while (@ob_end_flush()); //flush the buffers - save memory and disable sid rewrite
      mod/chat/gui_header_js/jsupdated.php:    @ob_end_flush();
      mod/chat/gui_header_js/jsupdated.php:            @ob_end_flush();
      mod/chat/gui_header_js/jsupdated.php:            @ob_end_flush();
      mod/chat/gui_header_js/jsupdated.php:        @ob_end_flush();
      search/indexer.php:@ob_end_flush();
      search/tests/index.php:    @ob_end_flush();

            skodak Petr Skoda
            stronk7 Eloy Lafuente (stronk7)
            Nobody Nobody (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.