Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-25276

Database drivers missing sql_cast_char2real() and associated tests

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Critical Critical
    • 2.0
    • 2.0
    • Database SQL/XMLDB
    • None
    • Any
    • MOODLE_20_STABLE
    • MOODLE_20_STABLE

      Was working on MDL-21437, when I detected that some fields that internally are using $DB->sql_cast_char2real(), weren't being properly casted, causing wrong sorts.

      Looking at drivers implementation, only moodle_database has one default implementation and moodle_pgsql_database a custom one.

      Also, tests were incomplete/inaccurate enough to cause us to think that everything was under control. So I'm going to implement the sql_cast_char2real() method for the drivers missing it and create/modify tests, to check for those implementations better.

      Ciao

            stronk7 Eloy Lafuente (stronk7)
            stronk7 Eloy Lafuente (stronk7)
            Nobody Nobody (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.