-
Bug
-
Resolution: Won't Fix
-
Critical
-
None
-
1.9.7
-
None
-
Debian Lenny Stable
PHP 5.2.11-0.dotdeb.1 with Suhosin-Patch 0.9.7 (cli) (built: Sep 19 2009 23:21:37)
Copyright (c) 1997-2009 The PHP Group
Zend Engine v2.2.0, Copyright (c) 1998-2009 Zend Technologies
Server version: Apache/2.2.9 (Debian)
Server built: Mar 28 2010 19:04:04
mysql Ver 14.12 Distrib 5.0.51a, for debian-linux-gnu (x86_64) using readline 5.2
Linux version 2.6.26-2-amd64 (Debian 2.6.26-21lenny4) (dannf@debian.org) (gcc version 4.1.3 20080704 (prerelease) (Debian 4.1.2-25)) #1 SMP Tue Mar 9 22:29:32 UTC 2010Debian Lenny Stable PHP 5.2.11-0.dotdeb.1 with Suhosin-Patch 0.9.7 (cli) (built: Sep 19 2009 23:21:37) Copyright (c) 1997-2009 The PHP Group Zend Engine v2.2.0, Copyright (c) 1998-2009 Zend Technologies Server version: Apache/2.2.9 (Debian) Server built: Mar 28 2010 19:04:04 mysql Ver 14.12 Distrib 5.0.51a, for debian-linux-gnu (x86_64) using readline 5.2 Linux version 2.6.26-2-amd64 (Debian 2.6.26-21lenny4) ( dannf@debian.org ) (gcc version 4.1.3 20080704 (prerelease) (Debian 4.1.2-25)) #1 SMP Tue Mar 9 22:29:32 UTC 2010
-
MySQL
-
MOODLE_19_STABLE
Hi,
This issue is closely related to MDL-22181 (it's a similiar bug, but this time in the forum module)
A brief description:
My school uses the "ID number" field on assignments and activities to match gradeables in moodle to gradeables in our SIS. This allows us to export marks from moodle to the SIS smoothly. The bug that has arisen is that if we have assigned an ID string in the "ID number" field in the "Common module settings" section of a forum activity, when postings on that forum are rated, the "ID number" field of the corresponding entry in the gradebook is replaced by a number. For example if we have a forum with the ID Number field set to "Discussion 1", every time a post on that forum is rated the ID number field of the forum activity in the gradebook (as accessed through the edit icon in the "Categories and Items – Simple view" page) will be changed from "Discussion 1" to "34526" (or some other number). The number it's being changed to is the value of the id field corresponding to the forum object in the mdl_course_modules table.
This seems to be the same sort of problem I reported in MDL-22181, only this time on the forum module. I've tracked down the error to the following lines:
1) Line #23 in mod/forum/rate.php
20 if (!$cm = get_coursemodule_from_instance('forum', $forum->id))
{ 21 error("Course Module ID was incorrect"); 22 }else
{ 23 $forum->cmidnumber = $cm->id; //MDL-12961 24 }line 23 should be: $forum->cmidnumber = $cm->idnumber; //MDL-12961
2) Line #86 in mod/forum/rate_ajax.php
82 /// Check coursemodule
83 if (!$cm = get_coursemodule_from_instance('forum', $forum->id))
else
{ 86 $forum->cmidnumber = $cm->id; //MDL-12961 87 }line 86 should be: $forum->cmidnumber = $cm->idnumber; //MDL-12961
I've tested this change on my testing server and it appears to solve the issue.
-Gord