-
Bug
-
Resolution: Fixed
-
Major
-
None
-
2.0
-
None
-
MOODLE_20_STABLE
Dongsheng - I am using moodle.jesuitscholar.com as a test server and tried to setup Dropbox repository when navigating to select a file, I receive a message about an invalid JSON string:
Notice: Undefined property: stdClass::$path in /home1/jesuits1/public_html/moodle/repository/dropbox/lib.php on line 134
Notice: Undefined property: stdClass::$contents in /home1/jesuits1/public_html/moodle/repository/dropbox/lib.php on line 163
Warning: Invalid argument supplied for foreach() in /home1/jesuits1/public_html/moodle/repository/dropbox/lib.php on line 164
{"list":[],"path":[
],"manage":false,"dynload":true,"nosearch":true,"repo_id":5}
I took a quick look and the logic about testing for whether $result->path is set seems like it could use a little attention. It seems to be used without being checked for on line 134, then it is checked for being empty and sets a current path. It looks like a general review of the get_listing function could be helpful in cleaning up some whitespacing issues as well.
I'm hoping I have everything entered for this to work. I did enter the Dropbox API key on the Moodle end.
Peace - Anthony
- will be (partly) resolved by
-
MDL-19168 Dropbox repository plugin
-
- Closed
-