Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-23925

make get_records() and friends use case and accent insensitive comparison consistently for all DB engines

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Fix
    • Icon: Major Major
    • 2.0
    • 1.9.9
    • Database SQL/XMLDB
    • None
    • MOODLE_19_STABLE
    • MOODLE_20_STABLE

      The problem is that the "=" in MySQL and MSSQL is using collation rules, in PostgreSQL and Oracle it is using binary string comparison. This is surprising for many developers, it creates major problems in glossary, tags, course shortnames, user names, etc. for non-english languages because different accent difference sometimes makes a work meaning different.

      After the like fixes in MDL-23888 it makes sense to fix get_records() and friends to make them use binary comparisons consistently via new $DB->sql_binary_comparison().

      I have discussed this with Eloy today, he seemed to be surprised too and gave +2 for commit...

            skodak Petr Skoda
            skodak Petr Skoda
            Nobody Nobody (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.