-
Bug
-
Resolution: Fixed
-
Major
-
1.9.9, 2.0, 2.4, 2.4.6, 2.5.2
-
MOODLE_19_STABLE, MOODLE_20_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
-
MOODLE_24_STABLE, MOODLE_25_STABLE
-
wip-mdl-23335-master
-
Multi-lang filtering is broken on the Frontpage News forum display. The problem is that the forum content is being shortened by forum_shorten_post() before the multi-lang filter can be applied through format_text().
The current code is...
mod/forum/lib.php ~line 3482 |
$postcontent = format_text(forum_shorten_post($post->message), $post->messageformat, $options, $course->id);
|
An untested possible solution is change the order of format_text and forum_shorten_post functions:
mod/forum/lib.php ~line 3482 |
$postcontent = forum_shorten_post(format_text($post->message, $post->messageformat, $options, $course->id));
|
Replication steps:
- Log in as admin
- Navigate to Site admin > Plugins > Filters > Manage filters
- Turn the Multi-Language Content filter to On
- Navigate to Site admin > Language > Language packs
- Ensure the English (en) and Français (fr) language packs are installed
- Navigate to Site admin > Front page > Front page settings
- For the Front page items when logged in settings, add News items
- Navigate to Home
- Under Site news, click Add a new topic
- Add an arbitrary title
- In the editor for the content, click the HTML button
- Paste the following content
<p><span class="multilang" lang="en">English english english english. English english english english. English english english english. English english english english. English english english english. English english english english. English english english english. English english english english. English english english english. English english english english. English english english english. English english english english. English english english english. English english english english. English english english english. English english english english. English english english english. English english english english. English english english english. English english english english. English english english english.</span><span class="multilang" lang="fr">French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. French french french french. </span></p>
- Click Update
- Click Save changes
- Click Home
- Switch languages between English and French
Expected result: The shortened message in the appropriate language should be shown
Actual result: The first language in the content (English) is always shown.
- blocks
-
MDL-40851 Finalise deprecation of function forum_shorten_post()
-
- Closed
-