Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-19118 Comments 2.0
  3. MDL-21957

do not use redirect messages if page not already started

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.0
    • 2.0
    • Comments
    • None
    • MOODLE_20_STABLE
    • MOODLE_20_STABLE

      The redirect should be always used before printing of page header, only if we have to do that afterwards the message may be actually needed because the user might have to press continue button.

      Now in the vast majority of cases the message in the fast redirect is absolutely useless because the user should actually see that something happened, or else they will get error, whitescree, etc - so the message would not be actually printed anyway.

      There is also the accessibility reason, the 3 second delay is confusing for most users...

      so in comment/admin.php the following is clearly wrong:
      redirect($CFG->httpswwwroot.'/comment/', get_string('deleted'));

      because you click on delete and you either get error when it can not be deleted, or the comment disappears and user can see that it was deleted

            dongsheng Dongsheng Cai
            skodak Petr Skoda
            Nobody Nobody (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.