Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-19118 Comments 2.0
  3. MDL-21952

DB update operations do not return bools any more, remove the result handling from comments

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: Blocker Blocker
    • 2.0
    • 2.0
    • Comments
    • None
    • MOODLE_20_STABLE
    • MOODLE_20_STABLE

      For a very long time the DB api is not returning bools from insert_record(), delete_records(), etc. the return true is there only for BC reasons, but no new code should actually test it because we use exceptions...

      Please remove the $return handling code from comments and rely only on exceptions which are already handled properly by the new ajax error handler

            dongsheng Dongsheng Cai
            skodak Petr Skoda
            Nobody Nobody (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.