Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-19118 Comments 2.0
  3. MDL-21945

do not pass by reference to plugin_callback

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: Blocker Blocker
    • 2.0
    • 2.0
    • Comments
    • None
    • MOODLE_20_STABLE
    • MOODLE_20_STABLE

      plugin_callback($this->plugintype, $this->pluginname, FEATURE_COMMENT, 'display', array(&$comments, $this->options));

      seems problematic because of the &$comments, why not simply use the return value from the callback?

            dongsheng Dongsheng Cai
            skodak Petr Skoda
            Nobody Nobody (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.