Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-21274

The 'Assign roles in course: x' button escapes html twice

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Fix
    • Icon: Minor Minor
    • None
    • 1.9.7
    • Libraries, Roles / Access
    • None
    • MySQL
    • MOODLE_19_STABLE
    • Easy

      I found this s() function to be a problem on the button for the Assign Roles in a Course page. The course name contains an & in it and in the DB was being stored as & which is fine, except that when it is pulled out of the DB to be used in the button text "Assign Roles in Course: _____" it was being run through this function so the source comes out looks like & and you see & in the course name.

      It can easily be fixed by swapping out the line in the print_single_button function to not use the s($label) and just use $label instead, but I thought that would be something that could be fixed in future releases?

            moodle.com Moodle HQ
            erinmayabb Erin Mayabb (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.