Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-20204 Themes 2.0: YUI, Caching, Performance, Consistency
  3. MDL-21147

do not use standard "get_x" methods for "magic" $PAGE stuff

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.0
    • 2.0
    • Themes
    • None
    • MOODLE_20_STABLE
    • MOODLE_20_STABLE

      I found it funny that ppl still use things like $PAGE->get_context() even if we have
      Please do not call this method directly, use the ->headerprinted syntax.

      {@link __get()}

      .
      in the pagelib.

      Solution is easy, use some really silly prefix like "magic_get_"
      This would allow us to implement true "get_" methods for things like $PAGE->get_renderer() which needs method parameters and can not be implemented through the __get magic.

            skodak Petr Skoda
            skodak Petr Skoda
            Nobody Nobody (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.