Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-20938

Wrong Colspan in Gradebook in Edit-Mode

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 1.9.7
    • 1.9.6
    • Gradebook
    • None
    • MOODLE_19_STABLE
    • MOODLE_19_STABLE

      If you activate edit mode in the grade book, the "Controls"-Field has a wrong colpsan (colspan='1' if no idnumber is shown, colspan='2' otherwise), see screenshots 2)(with cell boundaries highlighted).

      /cvsroot/moodle/moodle/grade/report/grader/lib.php
      lines 1300 following:
      $colspan = '';
      if ($showuseridnumber)

      { $colspan = 'colspan="2"'; }

      if (!$fixedstudents)

      { $iconshtml .= '<th class="header c0 controls" scope="row" '.$colspan.'>'.$this->get_lang_string('controls','grades').'</th>'; }

      should be:
      $colspan = 'colspan="2"';
      if ($showuseridnumber) { $colspan = 'colspan="3"'; }

      if (!$fixedstudents) { $iconshtml .= '<th class="header c0 controls" scope="row" '.$colspan.'>'.$this->get_lang_string('controls','grades').'</th>'; }

      I assume, a column was introduced and the code is old code.
      Similar lines (similar error??) are at lines 1173 and 1263.
      Screenshot 3) shows the right cell boundaries.

        1. lib.php.patch
          0.7 kB
        2. garder_avgs_ok.png
          garder_avgs_ok.png
          18 kB
        3. garder_avgs_ko.png
          garder_avgs_ko.png
          10 kB
        4. 3_Grades- View_boundaries_ok.png
          3_Grades- View_boundaries_ok.png
          4 kB
        5. 2_Grades- View_boundaries.png
          2_Grades- View_boundaries.png
          6 kB

            skodak Petr Skoda
            schuhmann Martin Schuhmann
            Andrew Davis Andrew Davis
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.