Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-20472

get_my_courses does not properly obey the limit parameter

XMLWordPrintable

    • MOODLE_19_STABLE
    • MOODLE_19_STABLE

      get_my_courses always returns 2 more courses than specified in $limit (if available).

      This is because of the way that it applied the limit.

      It does it using a counter as it steps through the courses. In this process, there are two off by one error.

      I have attached a diff that simplifies it somewhat (to read), and removes the two off by one errors.

        1. accesslib.diff
          0.5 kB
        2. datalib.diff
          0.5 kB

            emerrill Eric Merrill
            emerrill Eric Merrill
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.