Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-20057

Restore Silently Isn't Silent

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 1.9.5
    • 1.9.3
    • Backup
    • None
    • MOODLE_19_STABLE
    • MOODLE_19_STABLE
    • Easy

      Currently, restore_execute() [backup/restorelib.php] is not completely silent when RESTORE_SILENTLY.

      For Moodle 1.9.3 (as reference because xref still points at 1.9.3):

      7523 if ($status = restore_open_html($restore,$course_header))

      { 7524 echo "<li>Creating the Restorelog.html in the course backup folder</li>"; 7525 }

      Surrounding all other echoes in restore_execute() is this check:

      if (!defined('RESTORE_SILENTLY')) {

      Shouldn't the restorelog echo also be wrapped in a conditional that checks RESTORE_SILENTLY?

            danmarsden Dan Marsden
            ebollens Eric Bollens (Inactive)
            Rossiani Wijaya Rossiani Wijaya
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.