-
New Feature
-
Resolution: Inactive
-
Major
-
None
-
1.9.5
-
None
-
MOODLE_19_STABLE
-
Easy
In 'Site Administration"[Users][Accounts]-[Browse List of Users],
When we search the user newly, at first we must delete old active filters by pushing "Remove all filters".
We had developed a method to omit this troublesome work by adding new check box.
Let you try the new feature!
Patches for Moodle1.9 are as follows;
(adding one statement and one block, commenting out one statement only!)
(a) user/filters/lib.php
class user_filtering, function user_filtering()
foreach ($fieldnames as $fieldname=>$advanced) {
if ($field = $this->get_field($fieldname, $advanced))
}
// fist the new filter form
$this->_addform = new user_add_filter_form($baseurl, array('fields'=>$this->_fields, 'extraparams'=>$extraparams));
if ($adddata = $this->_addform->get_data(false)) {
// (Shirai): add from here
if (!empty($adddata->removealladd) && ($adddata->removealladd)) $SESSION->user_filtering = array();
// (Shirai): Add to here
foreach($this->_fields as $fname=>$field) {
$data = $field->check_data($adddata);
if ($data === false)
if (!array_key_exists($fname, $SESSION->user_filtering))
{ $SESSION->user_filtering[$fname] = array(); } $SESSION->user_filtering[$fname][] = $data;
}
(b) user/filters/user_filter_forms.php
class user_add_filter_form, function definition()
function definition() {
$mform =& $this->_form;
$fields = $this->_customdata['fields'];
$extraparams = $this->_customdata['extraparams'];
$mform->addElement('header', 'newfilter', get_string('newfilter','filters'));
foreach($fields as $ft)
{ $ft->setupForm($mform); } // in case we wasnt to track some page params
if ($extraparams) {
foreach ($extraparams as $key=>$value)
}
// Add button
// (Shirai): comment out this line
// $mform->addElement('submit', 'addfilter', get_string('addfilter','filters'));
// (Shirai): add from here
$objs = array();
$objs[] = &$mform->createElement('submit', 'addfilter', get_string('addfilter', 'filters'));
$objs[] = &$mform->createElement('checkbox', 'removealladd', null, 'Add filter after removing all');
$mform->addElement('group', 'addfiltergrp', '', $objs, ' ', false);
$mform->setDefault('removealladd', '0');
// (Shirai): add from here
// Don't use last advanced state
$mform->setShowAdvanced(false);
}
}
- has been marked as being related by
-
MDL-13912 Improvements to the search interface of admin's list of users
-
- Closed
-