Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-17284 Add Olli's new quiz editing UI to Moodle 2.0
  3. MDL-17298

We should not add JavaScript to the YAHOO namespace

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.0
    • 2.0
    • JavaScript, Quiz
    • None
    • MOODLE_20_STABLE
    • MOODLE_20_STABLE

      Sorry, this one is quite big. I don't know why I did not notice it before.

      We really should not be adding our code to the YAHOO library namespace. I would change

      YAHOO.cats.container -> question_bank
      YAHOO.quiz.container -> quiz_editor

      or something like that.

      <div id="module" is not very descriptive. Wouldn't something like id="questionbankcontents" be better?

      Do you really want to initialise on load, would onDomReady work better?

        1. edit_js_cleanup.patch.txt
          6 kB

            timhunt Tim Hunt
            timhunt Tim Hunt
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.