-
Bug
-
Resolution: Fixed
-
Major
-
None
-
1.9.2, 2.0
-
None
-
MOODLE_19_STABLE, MOODLE_20_STABLE
SCORM player.php is not inserting footer when SCORM is placed within the page. It's just hanging SCORM below the header and throws the footer out. That is very tragic: Moodle pages need always to include header and footer because we can add outer layout structures to Moodle pages opened in header which need to be closed in footer.
For a project I needed to find a solution for this issue:
player.php calls print_footer('none'); at the end. And in rd.js the #content div is calculated too to be a bit bigger than #scormobject.
When no footer shall be shown on SCORM pages you can hide unwanted parts in the theme with
if ($course != 'none')
and always close elements opened in the header.
Please confirm and add to Moodle as soon as possible.
Thank you very much.
The patch:
Index: player.php
===================================================================
RCS file: /cvsroot/moodle/moodle/mod/scorm/player.php,v
retrieving revision 1.34.2.4
diff -u -r1.34.2.4 player.php
— player.php 31 Jul 2008 22:31:04 -0000 1.34.2.4
+++ player.php 5 Aug 2008 15:23:49 -0000
@@ -374,11 +374,5 @@
?>
</div> <!-- SCORM object -->
</div> <!-- SCORM box -->
- </div> <!-- SCORM content -->
- <?php if (!empty($THEME->customcorners))
{
- print_container_end();
- }
?>
- </div> <!-- Content -->
- </div> <!-- Page -->
-</body>
-</html>
\ No newline at end of file
+ </div> <!-- SCORM page -->
+ <?php print_footer('none'); ?>
Index: rd.js
===================================================================
RCS file: /cvsroot/moodle/moodle/mod/scorm/rd.js,v
retrieving revision 1.1.2.2
diff -u -r1.1.2.2 rd.js-
- rd.js 28 Jul 2008 00:44:49 -0000 1.1.2.2
+++ rd.js 5 Aug 2008 15:23:49 -0000
@@ -72,6 +72,14 @@
var scoframe2 = document.getElementById('scoframe1');
document.getElementById('scormobject').style.height = (winheight - totalheight) + 'px';
}
+
+ // resize the content container too to move the footer below the SCORM content
+ var contenti3 = document.getElementById('content-i3');
+ if (contenti3) { + contenti3.style.height = (winheight - totalheight + 30) + 'px'; + }else
{ + document.getElementById('content').style.height = (winheight - totalheight + 30) + 'px'; + }
- rd.js 28 Jul 2008 00:44:49 -0000 1.1.2.2
-
}