Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-15594

Add a new site admin setting to disable/enable variables in the URL resource

XMLWordPrintable

    • MOODLE_19_STABLE, MOODLE_20_STABLE, MOODLE_402_STABLE
    • MOODLE_404_STABLE
    • MDL-15594-main
    • Hide

      New install

      1. Install a fresh Moodle instance which includes this patch.
      2. Login as admin.
      3. Go to Site administration > Plugins > Manage activities > URL.
      4. Confirm the "Allow URL variables" setting is shown and is disabled.

      Upgrade

      1. Install a previous version of Moodle which doesn't include this patch.
      2. Upgrade to the latest version of Moodle (including this patch).
      3. Login as admin.
      4. Go to Site administration > Plugins > Manage activities > URL.
      5. Confirm the "Allow URL variables" setting is shown and is enabled.

      Functionality

      1. Login as admin.
      2. Go to Site administration > Plugins > Manage Activities > URL.
      3. Set the "Allow URL variables" setting to enabled.
      4. Go to a course and create a new URL. Ensure at least 1 URL variable is set.
      5. View the URL. Confirm the variable is included in the link to the URL.
      6. Go to Site administration > Plugins > Manage activities > URL.
      7. Set the "Allow URL variables" setting to disabled.
      8. Go to the course and view the URL again. Confirm the variable is no longer included in the link to the URL.

      Everything else is covered by behat tests.

      Show
      New install Install a fresh Moodle instance which includes this patch. Login as admin. Go to Site administration > Plugins > Manage activities > URL . Confirm the "Allow URL variables" setting is shown and is disabled . Upgrade Install a previous version of Moodle which doesn't include this patch. Upgrade to the latest version of Moodle (including this patch). Login as admin. Go to Site administration > Plugins > Manage activities > URL . Confirm the "Allow URL variables" setting is shown and is enabled . Functionality Login as admin. Go to Site administration > Plugins > Manage Activities > URL . Set the "Allow URL variables" setting to enabled . Go to a course and create a new URL. Ensure at least 1 URL variable is set. View the URL. Confirm the variable is included in the link to the URL. Go to Site administration > Plugins > Manage activities > URL . Set the "Allow URL variables" setting to disabled . Go to the course and view the URL again. Confirm the variable is no longer included in the link to the URL. Everything else is covered by behat tests.
    • 3
    • Team Alpha - Sprint 2 I1-2024

      In the URL activity the Parameters functionality is problematic in a number of ways

      • its badly understood by users
      • it poses a GDPR and more general security risk to PII
      • it is an outdated and insecure way to integrate with an external website.

      To that end a global preference should be added in Site administration > Plugins > Manage activities > URL  to globally disable this functionality on a site.

      On upgrade this option should be Enabled with an upgrade note alerting administrators to this new option

      For all new installs this option should be Disabled by default.

        1. MDL-15594.png
          MDL-15594.png
          347 kB
        2. MDL-15594 functionality.png
          MDL-15594 functionality.png
          612 kB
        3. MDL-15594 new.png
          MDL-15594 new.png
          192 kB
        4. MDL-15594 upgrade.png
          MDL-15594 upgrade.png
          206 kB
        5. mdl191+_adding_new_resource_Parameters_section.png
          mdl191+_adding_new_resource_Parameters_section.png
          21 kB

            kevin.percy@moodle.com Kevin Percy
            chuang Wen Hao Chuang
            Mihail Geshoski Mihail Geshoski
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            13 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 2 hours, 10 minutes
                1d 2h 10m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.