Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-12101

bulk user operations cleanup/fixes

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Critical Critical
    • 1.9
    • 1.9
    • Administration
    • None
    • MOODLE_19_STABLE
    • MOODLE_19_STABLE

      There are several problems:
      1/ unitialized arrays - XSS
      2/ bad sql syntax - wrong quotes used in filters
      3/ incorrect use of formslib - not nice at all, very fragile and hackish
      4/ user filters ORed, should be ANDed - we can simulate OR by select all + clearing the filters, we can not do AND filters now
      5/ localization unfinished and problematic
      6/ hardcoded guest user id
      7/ some more...

      Solution:

      • split the forms
      • move the data processing logic from forms
      • general cleanup

        1. big_bulk1.patch
          136 kB

            skodak Petr Skoda
            skodak Petr Skoda
            Nobody Nobody (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.