Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-10074

User profile edition uses wrong variable for the (fatal) error message.

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 1.8.1, 1.9
    • 1.8, 1.9
    • Authentication
    • None
    • Any
    • MOODLE_18_STABLE, MOODLE_19_STABLE
    • MOODLE_18_STABLE, MOODLE_19_STABLE

      When the code in .../user/edit.php (and editadvanced.php) encounters an error trying to update the user details in the external authentication system, it displays an error using the value of $usernew->auth, which sometimes is not defined (e.g., when the user itself is editing his/her own profile). In addtition to that, the code actually tries to update the profile in the authentication system indicated by $user->auth (see line 69 in edit.php, where the call to get_auth_plugin is made()).

      So we should be really using $user->auth for the error message.

      I'm attaching a couple of patches for both 1.8 and 1.9dev, to fix this.

      Saludos. Iñaki.

        1. user-edit-18.diff
          1 kB
          Iñaki Arenaza
        2. user-edit-19.diff
          1 kB
          Iñaki Arenaza

            skodak Petr Skoda
            iarenaza Iñaki Arenaza
            Nobody Nobody (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.