Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-8596

Replace $bbbsession array by relevant object

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.0
    • 3.11

      The array $bbbsession is used many times in the mod_bigbluebuttonbn code and has several drawbacks:

      • We are not sure that the object is consistent across the code (it is initied and stored in the $SESSION in several locations: view_bbbsession_set, build_bbb_session). Basically, we are never entirely sure of what is in it.
      • It is stored in $SESSION variable sometimes
      • Part of the array store:
        • database information (bigbluebutton object)
        • current context (username, course, context)
        • bigbluebutton instance settings (openingtime, participant list...)
        • global settings (recordallfromstart, information on bbb server, general url such as logoutURL)
        • And more ( would need to check here if there is no info friom the server that would be cached in this array)

      Basically this has to be refactored. We could imagine to split it into different entities:

      1. An helper entity to retrieve global settings (or a small static class that would do just that)
      2. An helper to help and retrieve the right settings from the instance (and the logic behind each settings).
      3. Context information that would need to be shared across the same session. Let just make it as minimal as possible.
      4. Anything that can be cached would then need to be cached instead of stored in the session (if not linked to a session).

      The task is a bit daunting so it would likely be better to phase it in several stages.

            jfederico Jesus Federico
            lmdavid Laurent DAVID
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.