-
Bug
-
Resolution: Fixed
-
Minor
-
3.10.1
-
2.5
-
MOODLE_310_STABLE
-
MOODLE_400_STABLE
https://tracker.moodle.org/browse/MDL-70662
Description
A number of local PHP library function files are included in the plugin. These should be moved to appropriate class files in appropriately namespaced class files. Examples of these files include:
locallib.php
viewlib.php
brokerlib.php
This also includes functions included in endpoint files, for example:
bbb_view.php
Severity
Medium. All functions should be in an appropriately namespaced, auto-loaded class. This ensures that there are no dependencies on manual file inclusion, which can lead to errors and warnings depending on the code path taken.
Proposed solution
Move and update the affected local functions to be functions in appropriated namespaced classes.
Difficulty
Medium. This is not a difficult exercise but will likely be time-consuming. There may be some additional benefits to this work in that other code no-longer required for current Moodle versions can be removed.
- blocks
-
CONTRIB-8412 The methods in new namespaces / classes should not be prefixed bigblubuttonbn_
-
- Resolved
-
- is child of
-
MDL-70662 Migrate local library functions to namespaced class methods
-
- Closed
-
- is parent of
-
CONTRIB-8414 Change basic output function to renderers
-
- Resolved
-