Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-7137

Cleanup styles: remove inline styles, unnecessary css and use bootcamp base css instead for generic items like tables etc

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Major Major
    • None
    • 3.1.7, 3.1.8, 3.1.9, 3.2.4, 3.2.5, 3.2.6, 3.3.1, 3.3.2, 3.3.3, 3.4
    • Report: My Feedback
    • None
    • MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE

      According to Moodle developer docs, plugins should use bootcampbase css, rather than creating their own. That way themes can override the same classes and the colours won't clash with the theme.

      Currently the My Feedback plugin uses its own css for table backgrounds etc. These need to be changed to use bootcampbase css instead.

      See: https://docs.moodle.org/dev/CSS_Coding_Style#Barebones

       

      The only css that should be required is for items unique to the report. E.g. the processing indicator and dataTables features. Generic items like fonts, tables, tabs etc. should use the default Moodle styles.

       

      There is also some use of styles directly in the HTML which needs to be removed. The styles need a general cleanup.

            jgramp Jess Gramp (old account)
            jgramp Jess Gramp (old account)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.