Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-3259

Update for resizable window doesn't (always) work in IE. Options sent to window.open can be invalid

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Not a bug
    • Icon: Major Major
    • None
    • 1.9.14, 2.1.2
    • Module: Turnitintool
    • None
    • Seen in IE8 and IE9 - Firefox and Chrome ignore this setting anyway so it isn't an issue
    • MOODLE_19_STABLE, MOODLE_21_STABLE

      This patch - http://cvs.moodle.org/contrib/plugins/mod/turnitintool/turnitintool.js?r1=1.8&r2=1.8.2.1 - added ',resizable=1' onto the end of the options sent to window.open(). We found it didn't work and further investigation showed that the value of the 'option' variable only contained '1' (i.e. was an invalid parameter). Not sure why, but we are still looking.

      My take on this would be to remove the third (options) parameter from window.open() altogether - many browsers ignore it and (IHO) it's a bit 'rude' imposing on users the window parameters.

      I'm still looking at this and will add further info if/when I find it.

            paul.dawson Paul Dawson (Inactive)
            howardsmiller Howard Miller
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.