Uploaded image for project: 'Plugins'
  1. Plugins
  2. CONTRIB-3021

Module: Reservation - fix labels order of request table header

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • None
    • 1.9.8
    • None
    • MOODLE_19_STABLE

      Hi

      Reservation Module.
      I have noticed that labels grade and note are swapped in request table (mod/reservation/view.php).

      It needs such change:

      Index: mod/reservation/view.php
      ===================================================================
      --- mod/reservation/view.php	(wersja 857)
      +++ mod/reservation/view.php	(wersja 858)
      @@ -275,14 +275,15 @@
                       $tablecolumns[] = 'timecancelled';
                   }
       
      +            if (has_capability('mod/reservation:viewnote',$context) && ($reservation->note == 1)) {
      +                $tableheaders[] = get_string('note', 'reservation');
      +                $tablecolumns[] = 'note';
      +            }
      +
                   if (has_capability('mod/reservation:grade',$context) && ($reservation->maxgrade != 0) && ($now > $reservation->timestart)) {
                       $tableheaders[] = get_string('grade');
                       $tablecolumns[] = 'grade';
                   }
      -            if (has_capability('mod/reservation:viewnote',$context) && ($reservation->note == 1)) {
      -                $tableheaders[] = get_string('note', 'reservation');
      -                $tablecolumns[] = 'note';
      -            }
               }
       
               // Set up the table

            upo Roberto Pinna
            dracono Pawel Suwinski (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.